Support Grafana 'timeseries' panel type for analyse grafana.
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a workaround to parse the 'targets' out of a panel with type 'timeseries', not currently supported upstream. It also improves the error handling when an unknown panel type is encountered. When the functionality is merged upstream, this change can be removed.
8045d20 to
e956ee3
Compare
aknuds1
approved these changes
Nov 16, 2021
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
…na/cortex-tools#224) * Support Grafana 'timeseries' panel type for `analyse grafana`. This adds a workaround to parse the 'targets' out of a panel with type 'timeseries', not currently supported upstream. It also improves the error handling when an unknown panel type is encountered. When the functionality is merged upstream, this change can be removed. * Review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workaround to parse the 'targets' out of a panel with type
'timeseries', not currently supported upstream. It also improves the
error handling when an unknown panel type is encountered.
When the functionality is merged upstream, this change can be removed.