Chunktool add index-validate and index-clean commands #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add chunk index-validate command Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix linting error Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * use go 1.14.9 Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
replay
reviewed
Oct 24, 2020
pkg/chunk/cassandra/scanner.go
Outdated
| return | ||
| } | ||
|
|
||
| c, err := chunk.ParseExternalKey("fake", chunkID) |
There was a problem hiding this comment.
should this be hard-coded to fake?
There was a problem hiding this comment.
Good catch, it should be configurable but default to fake
* make flags consistent, update log messages and changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix errors Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * better named commands Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * refactor code a bit more Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * update readme Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * better help text * graceful error handling Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Jan 12, 2022
…-tools#104) * add "chunk clean" command * wrap error * load cortex config * load schema config * use yamlv2 for config file parsing * wip * fix threading * fixes * error handling * reset line counter * read file in another thread * parse hex * wrap original error * remove comments * feat: add chunk index-validate command (grafana/cortex-tools#103) * feat: add chunk index-validate command Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix linting error Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * use go 1.14.9 Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * cleanup input better * make flags consistent, update log messages and changelog (grafana/cortex-tools#105) * make flags consistent, update log messages and changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix errors Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * better named commands Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix changelog Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * refactor code a bit more Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * update readme Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * better help text * graceful error handling Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com> * Update changelog to 0.4.1 release * remove unneeded map Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * fix from/to ranges Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * log output for clean-index Co-authored-by: Mauro Stettler <mauro.stettler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.