Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance clock panel migration to set grafana datasource as default when on queries are in use #209

Merged
merged 7 commits into from
Sep 26, 2024

Conversation

academo
Copy link
Member

@academo academo commented Sep 26, 2024

This PR improves the migration logic in the clock panel to prevent clocks that use direct inputs instead of queries displaying possible datasource errors.

This might fix #200 but won't work 100% of all cases

@academo academo requested a review from a team as a code owner September 26, 2024 10:58
@academo academo requested review from oshirohugo and briangann and removed request for a team September 26, 2024 10:58
Copy link
Contributor

@briangann briangann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@academo academo merged commit 1bfd690 into main Sep 26, 2024
3 checks passed
@academo academo deleted the academo/enhance-clock-panel-migration branch September 26, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning received under v2.1.7
2 participants