Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration fix for new query type #192

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Migration fix for new query type #192

merged 14 commits into from
Jun 7, 2024

Conversation

briangann
Copy link
Contributor

@briangann briangann commented Jun 4, 2024

This PR is to fix the panel migrations for the non-query created clock panels. It will also cleanup the (angular) configs if they are found outside of the config block.

Other modifications:

  • Forces yarn V1
  • Updates to node 20
  • Bumps min Grafana version to 8.3+ (was 8.0)

TODO:

  • Migrates old panels and cleans up
  • Updates create-plugin changes
  • Adds basic playwright config (simple setup)

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024

CLA assistant check
All committers have signed the CLA.

@briangann briangann self-assigned this Jun 4, 2024
@briangann
Copy link
Contributor Author

almost ready with this one, the migration tests ironed out some issues, but still need to test some real instances with dashboards that are throwing the error, and also with query-enabled clocks.

@briangann briangann marked this pull request as ready for review June 6, 2024 22:52
@briangann briangann requested a review from a team as a code owner June 6, 2024 22:52
@briangann briangann requested review from Ukochka and removed request for a team June 6, 2024 22:52
@briangann
Copy link
Contributor Author

we'll need to update the docs in another PR, would like to get this fix out the door asap.

@briangann briangann changed the title WIP: migration fix for new query type Migration fix for new query type Jun 6, 2024
@briangann briangann merged commit 0618b30 into main Jun 7, 2024
5 checks passed
@briangann briangann deleted the briangann/add_migration branch June 7, 2024 19:36
@briangann
Copy link
Contributor Author

Fixes #189
Fixes #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants