Revert "Differentiation between metric and resource attributes (#984)" #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #999 +/- ##
==========================================
+ Coverage 80.75% 80.84% +0.09%
==========================================
Files 134 134
Lines 10733 10695 -38
==========================================
- Hits 8667 8646 -21
+ Misses 1559 1542 -17
Partials 507 507
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
…na#984)" (grafana#999) This reverts commit 84af0d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 84af0d1, as it was not a good approach.
PR #984 allowed specifying resource attributes per metric, but actually the same resource owns multiple metrics, so we must not let users to define different resource attributes depending on the exposed metric, as the result would be unpredictable.
In a future PR, the user will be able to define resource attributes per metric type: application, process, and network.