Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service when resolving k8s ips #992

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Use service when resolving k8s ips #992

merged 1 commit into from
Jul 3, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 3, 2024

This PR tries to address #933.

Resolving k8s IPs should try first to resolve via service instead of pods.

@marctc marctc requested review from grcevski and mariomac as code owners July 3, 2024 16:03
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks good, but I think we should remove the logging we added in the previous PR, since using the function I think creates new logger object every time and it will trigger regardless of the logging level.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (3f9fe7f) to head (9e6339f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #992      +/-   ##
==========================================
+ Coverage   80.73%   80.81%   +0.08%     
==========================================
  Files         134      134              
  Lines       10718    10721       +3     
==========================================
+ Hits         8653     8664      +11     
+ Misses       1560     1553       -7     
+ Partials      505      504       -1     
Flag Coverage Δ
integration-test 56.04% <0.00%> (-0.18%) ⬇️
k8s-integration-test 59.56% <100.00%> (+0.07%) ⬆️
oats-test 36.30% <0.00%> (-0.05%) ⬇️
unittests 50.71% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marctc marctc merged commit 683b50d into main Jul 3, 2024
6 checks passed
@marctc marctc deleted the fix_k8s_resolver branch July 3, 2024 17:46
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants