Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize InstrumentationSelection #965

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

mariomac
Copy link
Contributor

Replaces the map[string]bool internal implementation of InstrumentationSelection by a bitmap, which would save a considerable CPU time in scenarios with high throughput of spans.

@mariomac mariomac marked this pull request as ready for review June 25, 2024 14:44
@mariomac mariomac requested review from grcevski and marctc as code owners June 25, 2024 14:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.35%. Comparing base (1ca08e4) to head (f617bf6).

Files Patch % Lines
.../internal/export/instrumentations/instr_options.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   76.85%   80.35%   +3.50%     
==========================================
  Files         134      134              
  Lines       10477    10487      +10     
==========================================
+ Hits         8052     8427     +375     
+ Misses       1911     1558     -353     
+ Partials      514      502      -12     
Flag Coverage Δ
integration-test 56.03% <54.54%> (?)
k8s-integration-test 58.90% <45.45%> (-0.08%) ⬇️
oats-test 36.14% <50.00%> (-0.05%) ⬇️
unittests 49.03% <95.45%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sweet!

@mariomac mariomac merged commit 17f7878 into grafana:main Jun 26, 2024
6 checks passed
@mariomac mariomac deleted the optimize-instrselection branch June 26, 2024 08:11
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants