Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary filtered connection info map #963

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

grcevski
Copy link
Contributor

This map was used only for HTTP and is a relic from the time when we used purely a socket filter for tracking the HTTP requests. Since we now use tcp_sendmsg and tcp_readmsg, the direction information doesn't have to be stored and it's easy to compute.

This change saves memory and it also reduces the likelihood of getting the direction wrong, especially on port reuse.

@grcevski grcevski requested review from mariomac and marctc as code owners June 24, 2024 23:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.46%. Comparing base (e95a7d4) to head (82d644a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   75.92%   79.46%   +3.54%     
==========================================
  Files         132      132              
  Lines       10378    10378              
==========================================
+ Hits         7879     8247     +368     
+ Misses       1967     1608     -359     
+ Partials      532      523       -9     
Flag Coverage Δ
integration-test 54.50% <ø> (?)
k8s-integration-test 58.32% <ø> (-0.02%) ⬇️
oats-test 35.80% <ø> (ø)
unittests 47.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@grcevski grcevski merged commit 9b6a864 into grafana:main Jun 25, 2024
6 checks passed
@grcevski grcevski deleted the flow_direction branch June 25, 2024 13:00
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants