Fix default config value in Helm chart #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 79.41% 79.43% +0.01%
==========================================
Files 131 131
Lines 10330 10330
==========================================
+ Hits 8204 8206 +2
+ Misses 1605 1603 -2
Partials 521 521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mariomac
added a commit
to mariomac/beyla
that referenced
this pull request
Aug 2, 2024
This reverts commit e95a7d4.
marctc
pushed a commit
that referenced
this pull request
Aug 5, 2024
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* Revert "Fix default config value in Helm chart (grafana#961)" This reverts commit e95a7d4. * Helm Chart 1.3.0 with Beyla 1.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current default values for Helm chart is enabling Prometheus export by default.
This is problematic in the scenarios of pushing metrics via OTEL and configuring
a Prometheus scrapper for internal metrics (specially because I used also 9090).
The comment says that block is for internal metric reportings, which is not the case.
Changing to configure internal metrics instead.