-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up HTTP2 check #923
Speed up HTTP2 check #923
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
===========================================
- Coverage 78.92% 61.52% -17.41%
===========================================
Files 131 131
Lines 9862 9945 +83
===========================================
- Hits 7784 6119 -1665
- Misses 1572 3393 +1821
+ Partials 506 433 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
This PR adds a quick check for missed HTTP2 connections before we try to use the frame parser from Go. This reduces Beyla's CPU usage on the OTel demo from 25% to less than 3%.