-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report Redis failed calls #909
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 78.53% 78.62% +0.09%
==========================================
Files 132 132
Lines 9665 9688 +23
==========================================
+ Hits 7590 7617 +27
+ Misses 1565 1564 -1
+ Partials 510 507 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit cd4f89d.
This PR does couple of things:
db.system
for OTel attributes, only Prometheus. I've added that now and I updated the tests to explicitly check.