Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend allowed_attributes in network documentation #683

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

mariomac
Copy link
Contributor

Amend documentation to match the recent changes in this PR: #682

@mariomac mariomac requested a review from grafsean March 14, 2024 11:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.29%. Comparing base (4b26321) to head (adf27ae).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #683       +/-   ##
===========================================
- Coverage   76.93%   39.29%   -37.64%     
===========================================
  Files          96       93        -3     
  Lines        8016     7800      -216     
===========================================
- Hits         6167     3065     -3102     
- Misses       1508     4553     +3045     
+ Partials      341      182      -159     
Flag Coverage Δ
integration-test ?
unittests 39.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariomac mariomac merged commit 28cb938 into grafana:main Mar 14, 2024
6 checks passed
@mariomac mariomac deleted the allowed-attrs branch March 14, 2024 13:53
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
* Amend allowed_attributes in network documentation

* Fix vale errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants