Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: copy edits for cardinality measurement guide #1622

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

grafsean
Copy link
Contributor

@grafsean grafsean commented Feb 7, 2025

Copy edits for Mario's #1611

@grafsean grafsean added documentation Improvements or additions to documentation backport backport-2.0 backport release-2.0 labels Feb 7, 2025
@grafsean grafsean requested a review from mariomac February 7, 2025 10:37
docs/sources/cardinality.md Outdated Show resolved Hide resolved
19 metric buckets * 3 span kinds * #Instances * #Operations * #ReturnCodes
```

As depicted in the [previous example of calculation for application metrics](#example-of-calculation),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [doc-validator] reported by reviewdog 🐶
The anchor 'example-of-calculation' does not exist in the file 'docs/sources/cardinality.md'.
Replace the anchor with one of the available anchors.

Available anchors are: "beyla-metrics-cardinality, terminology, process-level-metrics, application-level-metrics, example-calculation, network-level-metrics, service-graph-metrics, span-metrics, case-study-cardinality-of-opentelemetry-demo, measure-process-level-metrics, measure-application-level-metrics, measure-network-level-metrics, measure-service-graph-metrics, measure-span-metrics"

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hello @grafsean!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (cdb8a7c) to head (3008ce4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   71.15%   71.13%   -0.02%     
==========================================
  Files         197      197              
  Lines       19871    19881      +10     
==========================================
+ Hits        14139    14143       +4     
- Misses       5055     5059       +4     
- Partials      677      679       +2     
Flag Coverage Δ
integration-test 52.85% <ø> (+0.36%) ⬆️
k8s-integration-test 53.13% <ø> (-0.08%) ⬇️
oats-test 34.69% <ø> (+0.02%) ⬆️
unittests 47.03% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grafsean grafsean merged commit d36ed36 into main Feb 7, 2025
15 checks passed
@grafsean grafsean deleted the grafsean/1611-copy-edits-1 branch February 7, 2025 13:41
github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
Co-authored-by: Mario Macias <mario.macias@grafana.com>
(cherry picked from commit d36ed36)
grafsean added a commit that referenced this pull request Feb 7, 2025
Co-authored-by: Mario Macias <mario.macias@grafana.com>
(cherry picked from commit d36ed36)

Co-authored-by: Sean Packham <sean.packham@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants