-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: copy edits for cardinality measurement guide #1622
Conversation
docs/sources/cardinality.md
Outdated
19 metric buckets * 3 span kinds * #Instances * #Operations * #ReturnCodes | ||
``` | ||
|
||
As depicted in the [previous example of calculation for application metrics](#example-of-calculation), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [doc-validator] reported by reviewdog 🐶
The anchor 'example-of-calculation' does not exist in the file 'docs/sources/cardinality.md'.
Replace the anchor with one of the available anchors.
Available anchors are: "beyla-metrics-cardinality, terminology, process-level-metrics, application-level-metrics, example-calculation, network-level-metrics, service-graph-metrics, span-metrics, case-study-cardinality-of-opentelemetry-demo, measure-process-level-metrics, measure-application-level-metrics, measure-network-level-metrics, measure-service-graph-metrics, measure-span-metrics"
Hello @grafsean!
Please, if the current pull request addresses a bug fix, label it with the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
- Coverage 71.15% 71.13% -0.02%
==========================================
Files 197 197
Lines 19871 19881 +10
==========================================
+ Hits 14139 14143 +4
- Misses 5055 5059 +4
- Partials 677 679 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Mario Macias <mario.macias@grafana.com> (cherry picked from commit d36ed36)
Copy edits for Mario's #1611