Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beyla_network_inter_zone_bytes metric #1600

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Feb 3, 2025

In addition to the decoration of beyla flow bytes metric with the src_zone and dst_zone, Beyla now enables a new counter metric that only reports flow bytes for inter-zone traffic (when src_zone != dst_zone).

The reasons for adding a new metric:

  • You don't have to add new attributes to the beyla_network_flow_bytes metric.
  • PromQL queries remain simpler (no need to join beyla_network_flow_bytes for different values of src/dst zones)
  • Can track inter-AZ traffic with different levels of granularity. You can keep inter-az traffic as simple as possible (only cluster and src/dst zones) or go to finest levels of granularity (e.g. source Pod) that would increase too much cardinality in the general-purpose beyla_network_flow_bytes` metric.

Documentation will go in a different PR.

@mariomac mariomac requested a review from a team as a code owner February 3, 2025 15:04
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 77.94118% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (6c4ea88) to head (39321e8).

Files with missing lines Patch % Lines
pkg/export/prom/prom_net.go 55.00% 16 Missing and 2 partials ⚠️
pkg/export/otel/metrics_net.go 72.72% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
- Coverage   71.01%   67.08%   -3.93%     
==========================================
  Files         197      197              
  Lines       19792    19871      +79     
==========================================
- Hits        14055    13331     -724     
- Misses       5058     5854     +796     
- Partials      679      686       +7     
Flag Coverage Δ
integration-test 52.56% <52.94%> (-0.20%) ⬇️
k8s-integration-test ?
oats-test 34.67% <35.29%> (+0.04%) ⬆️
unittests 47.04% <77.94%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very good idea!

@grcevski
Copy link
Contributor

grcevski commented Feb 3, 2025

I think it's OK to merge without the Clang tidy check passing, we can resolve that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants