-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beyla_network_inter_zone_bytes metric #1600
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1600 +/- ##
==========================================
- Coverage 71.01% 67.08% -3.93%
==========================================
Files 197 197
Lines 19792 19871 +79
==========================================
- Hits 14055 13331 -724
- Misses 5058 5854 +796
- Partials 679 686 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very good idea!
I think it's OK to merge without the Clang tidy check passing, we can resolve that later. |
In addition to the decoration of beyla flow bytes metric with the
src_zone
anddst_zone
, Beyla now enables a new counter metric that only reports flow bytes for inter-zone traffic (whensrc_zone != dst_zone
).The reasons for adding a new metric:
beyla_network_flow_bytes
metric.beyla_network_flow_bytes
for different values of src/dst zones)Documentation will go in a different PR.