Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes semantic conventions OTEL v1.30.0 #1578

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mariomac
Copy link
Contributor

The OTEL attribute db.system has been renamed to db.system.name.

If you are using Prometheus exporter, db_system has been also renamed to db_system_name.

@mariomac mariomac requested a review from a team as a code owner January 27, 2025 09:40
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (074e718) to head (4772c4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/request/span_getters.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
+ Coverage   71.20%   71.24%   +0.03%     
==========================================
  Files         197      197              
  Lines       19754    19755       +1     
==========================================
+ Hits        14066    14074       +8     
+ Misses       5006     5001       -5     
+ Partials      682      680       -2     
Flag Coverage Δ
integration-test 52.92% <68.42%> (+0.07%) ⬆️
k8s-integration-test 53.57% <26.31%> (+0.05%) ⬆️
oats-test 34.63% <78.94%> (-0.02%) ⬇️
unittests 47.30% <78.94%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyrille-leclerc
Copy link

cyrille-leclerc commented Jan 27, 2025

Do we have a config flag similar to otel.semconv-stability.opt-in=http,database? it also supports duplication with values like http/dup.
@zeitlinger, @matt-hensley, and @maryliag are super familiar with this.

@mariomac
Copy link
Contributor Author

@cyrille-leclerc no, we don't have it, that's why I preferred to ship this breaking change with a new major version number. But I guess that at some point we'll need to implement this flag.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit b535e56 into grafana:main Jan 27, 2025
14 checks passed
@mariomac mariomac deleted the semconv-1.30.0 branch January 27, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants