Change the way resource attributes are populated (unbreaks a 2.0 change) #1565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing internally with some users, there was a misinterpretation about the resource labels and attributes, so this PR:
Restores the
meta_source_labels
from version 1.9, but deprecates it and shows a warning if a user is still using it. There are new users adopting this option in the past days and would not be nice that one week after configuring everything, Beyla 2.0 breaks it.Adds the
resource_labels
option as a map, allowing to specify any OTEL resource attribute (not only limited to service name and NS). Currently only name and namespace are considered, but in a following PR, any other attribute is going to be forwarded as a resource attribute.The
resource.opentelemetry.io/
annotations are not configurable anymore, as they are an opinionated and standard way to configure any resource attribute, not only service name and namespace (like OTEL_RESOURCE_ATTRIBUTES). In a following PR, we will handle any resource attribute specified in this format.