-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host ID reporting to application metrics #1042
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1042 +/- ##
==========================================
- Coverage 81.46% 81.36% -0.10%
==========================================
Files 138 139 +1
Lines 10988 11073 +85
==========================================
+ Hits 8951 9010 +59
- Misses 1521 1549 +28
+ Partials 516 514 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Really awesome work!
* aws detector * gcp detector * all detectors. Still not integrated * combined host ID fetcher * first candidate * host-id but hostname should be the K8s node name * some tests * Working kube node machine id implementation * host ID in otel network metrics * target info in prom app metrics * integration tests * removed wrong nolint comment * more accurate description of FetchHostID * Fix hostIDregex in integration tests
This patch:
It also adds the
target_info
metric report to the Prometheus exporter, as there is required as standard way of reporting the host ID. This metric will be active when the prometheus exporter is active for any of the application metrics subgroup, and can't be disabled.