Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bpf_dbg_printk instead of bpf_printk #1026

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Use bpf_dbg_printk instead of bpf_printk #1026

merged 2 commits into from
Jul 17, 2024

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jul 16, 2024

bpf_printk is not propagating the info to user space as bpf_dbg_printk is doing.
Changing all to ocurrences to bpf_dbg_printk

@marctc marctc requested review from grcevski and mariomac as code owners July 16, 2024 13:26
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.64%. Comparing base (27dc018) to head (8806f2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1026      +/-   ##
==========================================
- Coverage   81.68%   81.64%   -0.04%     
==========================================
  Files         137      137              
  Lines       10923    10923              
==========================================
- Hits         8922     8918       -4     
- Misses       1494     1497       +3     
- Partials      507      508       +1     
Flag Coverage Δ
integration-test 56.29% <ø> (-0.09%) ⬇️
k8s-integration-test 59.00% <ø> (-0.07%) ⬇️
oats-test 37.41% <ø> (+0.07%) ⬆️
unittests 51.03% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing these.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@marctc marctc merged commit 1731edb into main Jul 17, 2024
6 checks passed
@marctc marctc deleted the replace_bpf_print branch July 17, 2024 09:26
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants