-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add headless service #3831
Conversation
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
62e0b7d
to
5347382
Compare
@@ -0,0 +1,29 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the amount of deployed resources small, can you make this optional by adding a new setting to the values.yaml?
I also think it should be opt-in for now rather than opt-out, since you only really need this when you're clustering and when you're not using go-discover to do the clustering.
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this more: what if we made the service toggleable and then just relied on turning the primary service into a headless service instead of adding a new service?
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
PR Description
This PR adds a headless service to our helm chart. Its main use case is for use with clustering, so that new pods can use it for an SRV lookup to fins the rest of the cluster peers to connect to.
It is a copy of the existing service definition but with a
-headless
suffix to the name and ClusterIP set explicitly to None.Comparing the previous manifests (exported with
helm template .
) and the new ones gives:Which issue(s) this PR fixes
Related to #2861 and ease-of-use.
Notes to the Reviewer
Nothing to note.
PR Checklist