Add usage reporter to track feature flags #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpaschalis
reviewed
Apr 29, 2022
mattdurham
reviewed
Apr 29, 2022
brendamuir
requested changes
May 2, 2022
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
brendamuir
approved these changes
May 2, 2022
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
brendamuir
approved these changes
May 2, 2022
tpaschalis
reviewed
May 2, 2022
tpaschalis
reviewed
May 2, 2022
tpaschalis
reviewed
May 2, 2022
Based on the past experiences of the Loki team, it's better to have this option |
brendamuir
approved these changes
May 4, 2022
tpaschalis
reviewed
May 5, 2022
tpaschalis
reviewed
May 5, 2022
tpaschalis
reviewed
May 5, 2022
Co-authored-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com>
tpaschalis
approved these changes
May 5, 2022
mattdurham
reviewed
May 18, 2022
pkg/usagestats/reporter.go
Outdated
| // The interval is based off the creation of the agent seed to avoid all agents reporting at the same time. | ||
| func nextReport(interval time.Duration, createdAt, now time.Time) time.Time { | ||
| // createdAt * (x * interval ) >= now | ||
| return createdAt.Add(time.Duration(math.Ceil(float64(now.Sub(createdAt))/float64(interval))) * interval) |
There was a problem hiding this comment.
Maybe separate this into a few statements for readability
brendamuir
reviewed
May 18, 2022
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
brendamuir
approved these changes
May 18, 2022
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
brendamuir
approved these changes
May 18, 2022
mattdurham
approved these changes
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the ability to pass the
usage-reportflag to the Grafana Agent to sendusage report of the enabled feature flags. The usage of this optional and disabled by default.
If enabled, it will send hourly the enabled flags to grafana.com.
Which issue(s) this PR fixes
Fixes #1488
Notes to the Reviewer
I followed a similar approach taken by grafana/loki#5361. I skipped
the part of leader selection when send the usage. I wasn't sure if we needed this bit.
I placed the initialization of the reporter in
entrypoint.,goin functionStart. Not sureif it should go there or somewhere else.
We can extend the reporter in the future to send any other kind of metrics.
PR Checklist