-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processes avatar_images
for gr.Chatbot
and icon
for gr.Button
correctly, so that respective files are moved to cache
#6379
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/0ffd4d0a1e2e190ad33810af31f3947f7b49dbc1/gradio-4.2.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@0ffd4d0a1e2e190ad33810af31f3947f7b49dbc1#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
avatar_images
for gr.Chatbot
and link
for gr.Button
correctly, so that respective files are moved to cacheavatar_images
for gr.Chatbot
and icon
for gr.Button
correctly, so that respective files are moved to cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems like it would be cleaner to move move_resource_to_block_cache
to be a Block
method, instead of having to pass self
everywhere it's called.
Thanks @aliabid94. That's a good idea, I'll make the change |
I'll refactor it so that the |
Then have postprocessing_utils.move_resource_to_block_cache just call the block.move_resource_to_block_cache? |
Made the refactor, and then also included a test using the |
Closes: #6329
Test with
chatbot_multimodal
demo