-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore query parameters in request #6327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
The demo notebooks don't match the run.py files. Please run this command from the root of the repo and then commit the changes: pip install nbformat && cd demo && python generate_notebooks.py Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/b5dcbe6c78839336a1041520e3a0f7d83a2aefe5/gradio-4.1.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@b5dcbe6c78839336a1041520e3a0f7d83a2aefe5#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
LGTM @aliabid94 |
abidlabs
approved these changes
Nov 7, 2023
abidlabs
reviewed
Nov 7, 2023
Merged
this is currently not working: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lost query parameters in the request in upgrading to 4.0, because we were sending the queue information (session_hash, fn_index) via query params - now we send both URL params and queue information via request.url_params.
This does mean that when a user searches the request for url_params, there will be additional url_parameters they will find now in 4.0. I wanted to strip these but the fastapi.Request object is immutable and would be very messy / hacky to create a new object without these URL parameters. I think this is okay because users are usually looking for a specific key when searching url parameters.
Fixes: #6283
Try with