Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data model for gr.DataFrame #6310

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Fix data model for gr.DataFrame #6310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b54f407
datamodel for df
abidlabs Nov 6, 2023
b8279f5
add changeset
gradio-pr-bot Nov 6, 2023
9d3a040
fix
abidlabs Nov 6, 2023
0eacb64
Merge branch 'fix-df-preprocessing' of github.com:gradio-app/gradio i…
abidlabs Nov 6, 2023
9e5836e
Add code
freddyaboulton Nov 6, 2023
42b2a55
reduce
freddyaboulton Nov 6, 2023
6b35149
trigger ci
freddyaboulton Nov 6, 2023
e7315ec
typing
abidlabs Nov 6, 2023
9d3cbd9
Merge branch 'add-brief-pause-gallery-test' into fix-df-preprocessing
abidlabs Nov 6, 2023
bf625a8
union
abidlabs Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/all-cougars-matter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"gradio": patch
---

fix:Fix data model for `gr.DataFrame`
6 changes: 2 additions & 4 deletions gradio/components/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@
class DataframeData(GradioModel):
headers: List[str]
data: List[List[Any]]
metadata: Optional[
Dict[str, List[Any]]
] = None # Optional[Dict[str, List[Any]]] = None
metadata: Optional[Dict[str, Optional[List[Any]]]] = None


set_documentation_group("component")
Expand Down Expand Up @@ -216,7 +214,7 @@ def postprocess(
return DataframeData(
headers=list(df.columns),
data=df.to_dict(orient="split")["data"], # type: ignore
metadata=self.__extract_metadata(value),
metadata=self.__extract_metadata(value), # type: ignore
)
elif isinstance(value, (str, pd.DataFrame)):
df = pd.read_csv(value) if isinstance(value, str) else value # type: ignore
Expand Down
1 change: 1 addition & 0 deletions js/app/test/gallery_component_events.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ test("Gallery preview mode displays all images correctly.", async ({
test("Gallery select event returns the right value", async ({ page }) => {
await page.getByRole("button", { name: "Run" }).click();
await page.getByLabel("Thumbnail 2 of 3").click();
await page.waitForTimeout(200);
expect(await page.getByLabel("Select Data")).toHaveValue(
"https://gradio-builds.s3.amazonaws.com/assets/lite-logo.png"
);
Expand Down
8 changes: 8 additions & 0 deletions test/test_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,14 @@ def test_component_functions(self):
dataframe_input = gr.Dataframe()
output = dataframe_input.preprocess(DataframeData(**x_data))
assert output["Age"][1] == 24

x_data = {
"data": [["Tim", 12, False], ["Jan", 24, True]],
"headers": ["Name", "Age", "Member"],
"metadata": {"display_value": None, "styling": None},
}
dataframe_input.preprocess(DataframeData(**x_data))

with pytest.raises(ValueError):
gr.Dataframe(type="unknown")

Expand Down