-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download button for audio #4977
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Was interested in getting involved and contributing, and saw this was one of the issues with the I thought to add a test for the addition like there was in that PR, but that file isn't in the repo anymore, so I thought maybe there's a different approach now. Happy to make any changes though! |
All the demos for this PR have been deployed at https://huggingface.co/spaces/gradio-pr-deploys/pr-4977-all-demos You can install the changes in this PR by running: pip install https://gradio-builds.s3.amazonaws.com/683bdf762311c71226d8274fa31eed4b0c74b593/gradio-3.38.0-py3-none-any.whl |
@abidlabs sure thing! I'll work on adding it in later today. |
Thanks @leuryr for the nice PR! Tested and everything lgtm |
🎉 Chromatic build completed! There are 27 visual changes to review. |
Actually let me revert real quickly, only because we are trying out a new changelog process. |
Ah ok, no worries. Thank you for the review @abidlabs , and looking forward to seeing the new changelog process implemented! I read over the PR a bit, and it looks like a substantial change, but one that will overall streamline the process. |
Description
show_download_button
param that determines download button visibility in static Audio components.Closes: #4087
Tests & Changelog
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.sh
You may need to run the linters:
bash scripts/format_backend.sh
andbash scripts/format_frontend.sh
Unless the pull request is labeled with the "no-changelog-update" label by a maintainer of the repo, all pull requests must update the changelog located in
CHANGELOG.md
:Please add a brief summary of the change to the Upcoming Release section of the
CHANGELOG.md
file and includea link to the PR (formatted in markdown) and a link to your github profile (if you like). For example, "* Added a cool new feature by
[@myusername](link-to-your-github-profile)
in[PR 11111](https://github.com/gradio-app/gradio/pull/11111)
".