Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Chatbot sharing payload too large #10637

Merged
merged 3 commits into from
Feb 20, 2025
Merged

Fix: Chatbot sharing payload too large #10637

merged 3 commits into from
Feb 20, 2025

Conversation

dawoodkhan82
Copy link
Collaborator

Description

  • Fixes Payload too large issue with chatbot sharing on spaces
  • If payload is too large, we now try to reduce the chatbot messages and try sharing.
  • If even one chatbot message is too large, we throw an error

Closes: #10606

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 20, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Storybook ready! Storybook preview
🦄 Changes detecting...

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/701b8cf983625d73bc8d5d8b5dbc4b7e999a39a0/gradio-5.16.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@701b8cf983625d73bc8d5d8b5dbc4b7e999a39a0#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/701b8cf983625d73bc8d5d8b5dbc4b7e999a39a0/gradio-client-1.12.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/701b8cf983625d73bc8d5d8b5dbc4b7e999a39a0/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/chatbot patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix: Chatbot sharing payload too large

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal looks good to me @dawoodkhan82 !

@abidlabs
Copy link
Member

Let's merge this in so that we can release later today!

@abidlabs abidlabs merged commit 75c9748 into main Feb 20, 2025
23 of 24 checks passed
@abidlabs abidlabs deleted the chatbot-share branch February 20, 2025 20:14
@dawoodkhan82
Copy link
Collaborator Author

@yvrjsharma noticed this didn't fix the issue for https://huggingface.co/spaces/ysharma/odr-dupe2. Taking a look, will open a new PR with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

413 Payload Too Large Error When Using Chatbot Share Button in Multistep Agent UI
4 participants