-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Independent scrolling of the code editor in an embedded Lite app in the playground mode #10575
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/86b3719433c1221d427ef499f8c7833a559e58b4/gradio-5.16.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@86b3719433c1221d427ef499f8c7833a559e58b4#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/86b3719433c1221d427ef499f8c7833a559e58b4/gradio-client-1.12.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/86b3719433c1221d427ef499f8c7833a559e58b4/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @whitphx, this makes sense and is a good idea. Right now though the changes only seem to work if the layout is explicitly set to "horizontal". and not when no layout is set.
Not a big deal though would just have to change the layout variable in Playground.svelte to default to "horizontal" instead of null
Thanks I didn't care that case, I pushed a fix. |
Cool merging in for the release! |
Description
When the editor is scrolled, the app is also moved, which is annoying.
Still WIP as there are some cases where it doesn't work as expected.Done