Skip to content

Commit

Permalink
fix(scheduler-targets): update kinesis firehose imports (aws#33615)
Browse files Browse the repository at this point in the history
### Issue # (if applicable)

Closes #<issue number here>.

### Reason for this change

The Kinesis Firehose module is now stabilized, need to update package imports accordingly.

### Description of changes

Fix import paths for Kinesis Firehose target

### Describe any new or updated permissions being added

n/a

### Description of how you validated changes

Updated integration test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
gracelu0 authored Mar 2, 2025
1 parent 183556d commit 1df1a78
Show file tree
Hide file tree
Showing 12 changed files with 7,982 additions and 3,809 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { IDeliveryStream } from '@aws-cdk/aws-kinesisfirehose-alpha';
import { IScheduleTarget } from '@aws-cdk/aws-scheduler-alpha';
import { IRole, PolicyStatement } from 'aws-cdk-lib/aws-iam';
import { IDeliveryStream } from 'aws-cdk-lib/aws-kinesisfirehose';
import { ScheduleTargetBase, ScheduleTargetBaseProps } from './target';

/**
Expand Down
5 changes: 0 additions & 5 deletions packages/@aws-cdk/aws-scheduler-targets-alpha/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@
},
"license": "Apache-2.0",
"devDependencies": {
"@aws-cdk/aws-kinesisfirehose-destinations-alpha": "0.0.0",
"@aws-cdk/aws-kinesisfirehose-alpha": "0.0.0",
"@aws-cdk/aws-scheduler-alpha": "0.0.0",
"@aws-cdk/cdk-build-tools": "0.0.0",
"@aws-cdk/integ-runner": "0.0.0",
Expand All @@ -93,10 +91,7 @@
"aws-cdk-lib": "0.0.0",
"constructs": "^10.0.0"
},
"dependencies": {},
"peerDependencies": {
"@aws-cdk/aws-kinesisfirehose-destinations-alpha": "0.0.0",
"@aws-cdk/aws-kinesisfirehose-alpha": "0.0.0",
"@aws-cdk/aws-scheduler-alpha": "0.0.0",
"aws-cdk-lib": "^0.0.0",
"constructs": "^10.0.0"
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import * as firehose from '@aws-cdk/aws-kinesisfirehose-alpha';
import * as destinations from '@aws-cdk/aws-kinesisfirehose-destinations-alpha';
import * as scheduler from '@aws-cdk/aws-scheduler-alpha';
import { AwsApiCall, ExpectedResult, IntegTest } from '@aws-cdk/integ-tests-alpha';
import * as cdk from 'aws-cdk-lib';
import * as firehose from 'aws-cdk-lib/aws-kinesisfirehose';
import { Bucket } from 'aws-cdk-lib/aws-s3';
import { KinesisDataFirehosePutRecord } from '../lib';

Expand Down Expand Up @@ -31,7 +30,7 @@ const deliveryStreamRole = new cdk.aws_iam.Role(stack, 'deliveryStreamRole', {
destinationBucket.grantReadWrite(deliveryStreamRole);

const firehoseStream = new firehose.DeliveryStream(stack, 'MyFirehoseStream', {
destination: new destinations.S3Bucket(destinationBucket, {
destination: new firehose.S3Bucket(destinationBucket, {
role: deliveryStreamRole,
bufferingInterval: cdk.Duration.minutes(1),
}),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as firehose from '@aws-cdk/aws-kinesisfirehose-alpha';
import { ScheduleExpression, Schedule, Group } from '@aws-cdk/aws-scheduler-alpha';
import { App, CfnResource, Duration, Stack } from 'aws-cdk-lib';
import { Template } from 'aws-cdk-lib/assertions';
import { AccountRootPrincipal, Role } from 'aws-cdk-lib/aws-iam';
import * as firehose from 'aws-cdk-lib/aws-kinesisfirehose';
import * as sqs from 'aws-cdk-lib/aws-sqs';
import { Construct } from 'constructs';
import { KinesisDataFirehosePutRecord } from '../lib';
Expand Down

0 comments on commit 1df1a78

Please sign in to comment.