Default value for options to be empty hash #17
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a crash occurring for a pod omitting the
:binary
option. I believe its default value should befalse
. With the plugin enabled, the expected behavior ofpod 'MyPod'
is that it should just work like normal, no binary caching involved. The actual crash is occurring on line13
where it's checking ifoptions
is empty when it's actuallynil
. Interestingly enough, if a version string is the last requirement it will not crash sinceempty?
is a method shared between strings and hashes. So this actually works:pod 'MyPod', '~> 1.0'
. But if you remove the version string, it crashes.