Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for options to be empty hash #17

Closed
wants to merge 1 commit into from
Closed

Default value for options to be empty hash #17

wants to merge 1 commit into from

Conversation

lazyvar
Copy link

@lazyvar lazyvar commented Aug 18, 2020

Currently there is a crash occurring for a pod omitting the :binary option. I believe its default value should be false. With the plugin enabled, the expected behavior of pod 'MyPod' is that it should just work like normal, no binary caching involved. The actual crash is occurring on line 13 where it's checking if options is empty when it's actually nil. Interestingly enough, if a version string is the last requirement it will not crash since empty? is a method shared between strings and hashes. So this actually works: pod 'MyPod', '~> 1.0'. But if you remove the version string, it crashes.

@lazyvar lazyvar mentioned this pull request Aug 18, 2020
@trinhngocthuyen
Copy link
Contributor

Hi @lazyvar,
The change LGTM.
However, as this repo is a mirror-repo of an internal repo. I am going to submit an update internally to include this change.
Thanks for your contribution.

@trinhngocthuyen
Copy link
Contributor

The change is included in d2ea5f5. Thanks!

@lazyvar
Copy link
Author

lazyvar commented Sep 13, 2020

👍

@lazyvar lazyvar closed this Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants