fix: add showLinkIframe and showLinkButton in settings with tests (#878)

* fix: add showLinkIframe and showLinkButton in settings with tests

* refactor: fix tests

src/services/item/fluent-schema.ts

@@ -31,7 +31,10 @@ const settings = S.object()
   .prop('displayCoEditors', S.boolean())
   .prop('descriptionPlacement', S.enum(Object.values(DescriptionPlacement)))
   .prop('isCollapsible', S.boolean())
-  .prop('enableSaveActions', S.boolean());
+  .prop('enableSaveActions', S.boolean())
+  // link settings
+  .prop('showLinkIframe', S.boolean())
+  .prop('showLinkButton', S.boolean());
 
 export const partialMember = S.object()
   .additionalProperties(false)

src/services/item/plugins/embeddedLink/embeddedLink.test.ts

@@ -86,6 +86,10 @@ describe('Link Item tests', () => {
             },
           },
           description: iframelyMeta.description,
+          settings: {
+            showLinkIframe: false,
+            showLinkButton: true,
+          },
         };
 
         // check response value

src/services/item/plugins/embeddedLink/index.ts

@@ -77,6 +77,13 @@ const plugin: FastifyPluginAsync<GraaspEmbeddedLinkItemOptions> = async (fastify
     embeddedLink.icons = links
       .filter(({ rel }: { rel: string[] }) => hasIconRel(rel))
       .map(({ href }) => href);
+
+    // default settings
+    item.settings = {
+      showLinkButton: true,
+      showLinkIframe: false,
+      ...(item.settings ?? {}),
+    };
   };
 
   itemService.hooks.setPreHook('create', hook);

src/services/item/plugins/file/service.ts

@@ -147,7 +147,8 @@ class FileItemService {
         }
       }
 
-      return newItem;
+      // retrieve item again since hasThumbnail might have changed
+      return repositories.itemRepository.get(newItem.id);
     });
   }
 

src/services/item/test/fixtures/items.ts

@@ -136,6 +136,12 @@ export const expectItem = (
   if (newItem.creator && creator) {
     expect(newItem.creator.id).toEqual(creator.id);
   }
+
+  if (correctItem.settings) {
+    for (const [k, s] of Object.entries(correctItem.settings)) {
+      expect(newItem.settings![k]).toEqual(s);
+    }
+  }
 };
 
 export const expectManyItems = (

src/services/item/test/index.test.ts

@@ -272,7 +272,7 @@ describe('Item routes tests', () => {
         });
 
         const newItem = response.json();
-        expectItem(newItem, payload, actor);
+        expectItem(newItem, { ...payload, settings: VALID_SETTING }, actor);
         expect(response.statusCode).toBe(StatusCodes.OK);
         expect(newItem.settings.descriptionPlacement).toBe(VALID_SETTING.descriptionPlacement);
         expect(Object.keys(newItem.settings)).not.toContain(Object.keys(BAD_SETTING)[0]);
@@ -1997,6 +1997,35 @@ describe('Item routes tests', () => {
         expect(newItem.settings.hasThumbnail).toBeFalsy();
       });
 
+      it('Update successfully link settings', async () => {
+        const { item } = await saveItemAndMembership({
+          member: actor,
+        });
+        const payload = {
+          settings: {
+            showLinkButton: false,
+            showLinkIframe: true,
+          },
+        };
+
+        const response = await app.inject({
+          method: HttpMethod.Patch,
+          url: `/items/${item.id}`,
+          payload,
+        });
+
+        const newItem = response.json();
+
+        expectItem(newItem, {
+          ...item,
+          ...payload,
+        });
+        expect(response.statusCode).toBe(StatusCodes.OK);
+        expect(newItem.settings.showLinkButton).toBe(false);
+        expect(newItem.settings.showLinkIframe).toBe(true);
+        expect(newItem.settings.hasThumbnail).toBeFalsy();
+      });
+
       it('Filter out bad setting when updating', async () => {
         const BAD_SETTING = { INVALID: 'Not a valid setting' };
         const VALID_SETTING = { descriptionPlacement: DescriptionPlacement.ABOVE };
@@ -2024,6 +2053,7 @@ describe('Item routes tests', () => {
         expectItem(newItem, {
           ...item,
           ...payload,
+          settings: VALID_SETTING,
         });
         expect(response.statusCode).toBe(StatusCodes.OK);
         expect(newItem.settings.descriptionPlacement).toBe(VALID_SETTING.descriptionPlacement);