-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add corrections #218
Conversation
pyphilia
commented
May 30, 2024
- reduce espace entre Documents / elements
- truncate title for item in header
- refactor item list to add more margin on the right for option button
- Add menu list item to show qr code
- Share link only for builder
- Show message in player for folders having only folders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I am not familiar with how the stacks and titles are rendered, so maybe it is not possible to have dynamic truncation on the container width (like how ellipsis
work on web).
|
The Stack navigation is quite cumbersome, you need to have some requirements to make the automatic ellipsis work:
I've chosen the 2nd solution, except for file and video that had three buttons in the right location (those have manually set title max width). Moving to a setting button can solve that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Sorry to hear about the limitations 😢