Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add corrections #218

Merged
merged 3 commits into from
Jun 5, 2024
Merged

feat: add corrections #218

merged 3 commits into from
Jun 5, 2024

Conversation

pyphilia
Copy link
Contributor

  • reduce espace entre Documents / elements
  • truncate title for item in header
  • refactor item list to add more margin on the right for option button
  • Add menu list item to show qr code
  • Share link only for builder
  • Show message in player for folders having only folders

@pyphilia pyphilia requested a review from spaenleh May 30, 2024 12:27
@pyphilia pyphilia self-assigned this May 30, 2024
@pyphilia pyphilia marked this pull request as ready for review May 30, 2024 12:28
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I am not familiar with how the stacks and titles are rendered, so maybe it is not possible to have dynamic truncation on the container width (like how ellipsis work on web).

Copy link

sonarqubecloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pyphilia
Copy link
Contributor Author

pyphilia commented Jun 4, 2024

The Stack navigation is quite cumbersome, you need to have some requirements to make the automatic ellipsis work:

  • not enable back title, which allows very small left and right margins. Having long titles can have ellipsis, but the right content will never be visible/overflow over the text.
  • have back button (either default text or ' ' ) + align center will allow at most two buttons to be displayed alongside a long title with ellipsis. The downside of this is a big right margin if there's no button

I've chosen the 2nd solution, except for file and video that had three buttons in the right location (those have manually set title max width). Moving to a setting button can solve that.

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Sorry to hear about the limitations 😢

@pyphilia pyphilia merged commit ea2d09c into main Jun 5, 2024
4 checks passed
@pyphilia pyphilia deleted the corrections branch June 5, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants