-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple input tools in same phase "share" content #136
Comments
Thanks for reporting this. I have been able to reproduce. Looking into possible solutions. |
We know the AppInstance ID of the app that sends a message to the desktop. We now append this ID to the message. Therefore, when responding to the message, we only send it if the AppInstance ID matches the one on the PhaseApp component. closes #136
@jakob-sikken, this has been fixed in v0.11.1. Kindly let me know if it works for you. Thanks! |
I am still getting some warnings that a "reply" is delivered at the wrong iframe. But now all twente apps are at least starting up. |
@jakob-sikken, you are right. For me it's working intermittently (as shown below), which means that there is something that is not consistently working as expected. Will reopen and look into it. |
@jakob-sikken, we have released another fix in v0.11.2. Please let us know if that works for you. Thanks! https://github.com/graasp/graasp-desktop/releases/tag/v0.11.2 |
I don't see any changes. The problems are still there. |
@jakob-sikken, thanks for reporting. I'm indeed seeing the intermittent issue again for resources. However, for the configuration (e.g. header / no header), it seems to be working fine. Can you confirm that if you have two input boxes with different configs they indeed load differently? |
Yes, the configurations are loaded by the correct instance. |
@jakob-sikken, thanks for your response. I believe that the problem is now at the level of the input app. I'm addressing this here: |
@jakob-sikken, I did some more digging and indeed there is a concurrency issue with some channels in the desktop application, so I will reopen this issue and address this. |
@jakob-sikken, I made another change and released v0.11.3. Kindly check if it solves the problems you were seeing. https://github.com/graasp/graasp-desktop/releases/tag/v0.11.3 |
It seems that most problems are solved. However at start-up a few warnings from our tools, about receiving an unexpected message. But I have difficulty repeating them. I made you owner of the ILS that I use for testing. |
If you place two input tools in the same phase, the saved content of the first input is also shown in the second input after reloading.
It seems that the handling on which window/iframe a storage callback should be done is failing.
This is happens also when multiple twente tools are placed in the same phase, callbacks are sometimes applied at the wrong instance.
The text was updated successfully, but these errors were encountered: