Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple input tools in same phase "share" content #136

Closed
jakob-sikken opened this issue Jul 17, 2019 · 12 comments · Fixed by #137
Closed

Multiple input tools in same phase "share" content #136

jakob-sikken opened this issue Jul 17, 2019 · 12 comments · Fixed by #137
Assignees
Labels
bug Something isn't working

Comments

@jakob-sikken
Copy link
Contributor

If you place two input tools in the same phase, the saved content of the first input is also shown in the second input after reloading.
It seems that the handling on which window/iframe a storage callback should be done is failing.
This is happens also when multiple twente tools are placed in the same phase, callbacks are sometimes applied at the wrong instance.

@juancarlosfarah
Copy link
Member

Thanks for reporting this. I have been able to reproduce. Looking into possible solutions.

@juancarlosfarah juancarlosfarah self-assigned this Jul 17, 2019
@juancarlosfarah juancarlosfarah added the bug Something isn't working label Jul 17, 2019
juancarlosfarah added a commit that referenced this issue Jul 17, 2019
We know the AppInstance ID of the app that sends a message to the
desktop. We now append this ID to the message. Therefore, when
responding to the message, we only send it if the AppInstance ID
matches the one on the PhaseApp component.

closes #136
@juancarlosfarah
Copy link
Member

@jakob-sikken, this has been fixed in v0.11.1. Kindly let me know if it works for you. Thanks!

@jakob-sikken
Copy link
Contributor Author

I am still getting some warnings that a "reply" is delivered at the wrong iframe. But now all twente apps are at least starting up.
And in case of a phase with two input boxes, the second input box still shows the same content as the first input box.

@juancarlosfarah
Copy link
Member

@jakob-sikken, you are right. For me it's working intermittently (as shown below), which means that there is something that is not consistently working as expected. Will reopen and look into it.

image

@juancarlosfarah
Copy link
Member

@jakob-sikken, we have released another fix in v0.11.2. Please let us know if that works for you. Thanks!

https://github.com/graasp/graasp-desktop/releases/tag/v0.11.2

@jakob-sikken
Copy link
Contributor Author

I don't see any changes. The problems are still there.

@juancarlosfarah
Copy link
Member

@jakob-sikken, thanks for reporting. I'm indeed seeing the intermittent issue again for resources. However, for the configuration (e.g. header / no header), it seems to be working fine. Can you confirm that if you have two input boxes with different configs they indeed load differently?

@jakob-sikken
Copy link
Contributor Author

Yes, the configurations are loaded by the correct instance.

@juancarlosfarah
Copy link
Member

@jakob-sikken, thanks for your response. I believe that the problem is now at the level of the input app. I'm addressing this here:

graasp/graasp-app-text-input#20

@juancarlosfarah
Copy link
Member

@jakob-sikken, I did some more digging and indeed there is a concurrency issue with some channels in the desktop application, so I will reopen this issue and address this.

@juancarlosfarah
Copy link
Member

@jakob-sikken, I made another change and released v0.11.3. Kindly check if it solves the problems you were seeing.

https://github.com/graasp/graasp-desktop/releases/tag/v0.11.3

@jakob-sikken
Copy link
Contributor Author

It seems that most problems are solved. However at start-up a few warnings from our tools, about receiving an unexpected message. But I have difficulty repeating them. I made you owner of the ILS that I use for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants