"About" not working

[RolaSay]

Using Win10. When I choose About from the menu, I don't get anything.
I should see the info and version pop-up, but I don't.

[juancarlosfarah]

Hi @RolaSay, thanks for your feedback. Could you please provide a screenshot, if possible? @pyphilia, do you see this on your version of Windows?

[bootsa]

Same for Linux (cloned repo, master branch, 0.10.1). Click on File > About, menu closes but no pop up window or any other sign of response (no response in DevTools console either).
File menu heading stays highlighted (but that's same for other menu response: e.g. Edit > Cut) - see screenshot.

(There seems to be a small empty menu entry between File and Edit that does nothing when clicked - guess this is just used as a spacer).

[RolaSay]

I normally would. But since nothing is shown when selecting File --> About, I didn't.

[juancarlosfarah]

I have been able to reproduce on Windows. Thanks @RolaSay for reporting.

[juancarlosfarah]

@pyphilia, could you please have a look at this? I think it's just some config that needs to be added. Prioritise Windows.

[bootsa]

Looks like Electron only has an About role for Mac (as it uses a native MacOS function).

This package (https://www.npmjs.com/package/about-window) looks like it would provide cross-platform support.

If I get the chance I'll try it out and attempt a pull request.

[juancarlosfarah]

Thanks for the comment @bootsa. @pyphilia is looking into this now. Will let you know if we resolve it.

[juancarlosfarah]

In any case, this is what we should be showing:

[pyphilia]

I created a fix here 27b8826
Thank you for the tip @bootsa This package works very well.
However I experimented my electron browser getting erased. I guess it is happening during this package installation, I am not sure. We should test it.

The error I got when running after package installation:
Error: Cannot find module '[...]resources/electron.asar/browser/init.js'
where indeed the whole resources folder disappeared. Copying this folder back fixed the issue.

[juancarlosfarah]

@pyphilia, it looks fine to me. Can you create a PR please?

[bootsa]

Sorry for the delay in replying. On Linux (and probably Windows) each new window has the main menu attached so it appears in the About Window. This pull request should fix it.

Out of interest, wouldn't keeping the MacOS menu system (with items like About under the application menu entry) help with navigation due to familiarity? The example on the electron menu page has a good implementation - though it's missing a vital line:

const isMac = process.platform === 'darwin';

[juancarlosfarah]

@bootsa, thanks for your feedback. I agree that keeping the macOS menu system would be a good idea. @pyphilia, could you kindly look into this? Thanks!

[juancarlosfarah]

@pyphilia, you can always test the Mac bit on the iMac and open a new PR if you think it works well!

[juancarlosfarah]

Hmm. I built the new version and see some difference. It looks like it's using the graasp-desktop name and not Graasp. We also seem to be missing some of the help elements in the menu.

Previous Version

Current Version

@pyphilia, perhaps open a new PR and go with @bootsa's suggestion?

[pyphilia]

@juancarlosfarah I couldn't reproduce your menu bar. I built from master and had this on the iMac

[juancarlosfarah]

@pyphilia, that's how it should look, but I believe you might not have the latest commit. Did you run yarn dist (make sure you have a copy of the .env file) and open the resulting dmg in dist/?

[pyphilia]

I arrange it a bit.
What I opened was the file in the mac folder after running yarn dist. I can indeed notice the difference in the menu but I am not sure why?