Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promisify upload #46

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Promisify upload #46

wants to merge 30 commits into from

Conversation

ugGit
Copy link
Contributor

@ugGit ugGit commented Aug 9, 2020

The function uploadToS3() should make the upload of the build directory to AWS using a promise. Somehow, the function fails to upload one (or multiple) file(s) with the following error message:

Error: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be one of type Buffer, TypedArray, DataView, string, or KeyObject. Received type undefined

Where Key is referencing the attribute in the s3.upload() function.

Uchendu Nwachukwu added 30 commits July 9, 2020 16:47
chore: add prettier style as usual for graasp apps
18deca4
feat: add basic new command
d248ef0
feat: load dev env and deploy to aws
70c76dc
refactor: rm test file and rm obsolet promisify()
305efa0
refactor: remove accidentally added bash script
53925c3
feat: add options and validation
68fb33b
feat: invalidate cache after deployment
00f48a7
fix: allow console output in eslint
8ba8262
feat: add a fancy progress bar
96d3531
fix: tag validation and accidental async
7ac7faa
chore: add comment to RegExp and backshlashes
dc383ad
refactor: rename varIsDefined() to isDefined()
c37afb8
refactor: remove unused env varas from import
305cb3b
refactor: replace unnamed func with arrow func
19eb223
fix: minor changes based on feedback on pr
820b5f5
chore: remove obsolete comment
ad0f6f6
refactor: factor validation out
5687b3b
fix: use proper tag validation
cb5650a
chore: add explanation to regexp
6b38e41
fix: remove default env
f4b79ef
refactor: replace isdefined() with lodash
3cf0366
chore: enable linting warning for console log
e85ac36
Merge branch 'master' of github.com:graasp/graasp-cli into deploy-cmd
baaa792
chore: try out promisify
2338ead
chore: force commit with eslint errors
4491092
feat: load sync aws credentials
62ea0f8
chore: update flag descriptions
89e8821
chore: assemble error outputs in together
7a288e8
chore: remove obsolete default env variable
28a0dc5
chore: first version of promise for upload
3e19e19
@ugGit ugGit requested a review from juancarlosfarah August 9, 2020 22:29
@juancarlosfarah juancarlosfarah self-assigned this Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@juancarlosfarah juancarlosfarah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugGit @juancarlosfarah