Version1 #3
Version1 #3
Conversation
…add package excalidraw
There was a problem hiding this comment.
Thank you for this nice first PR!
I asked for a lot of small changes. Please, review as many of them as you can and don't hesitate to ask me questions, either by directly answering my comments or sending me an email. We can also set up a meeting.
The most important comments are the ones on the code that you wrote and that should be taken into account by the end of the project. Try to focus on these then.
And don't be afraid of the number of comments, it is a lot of small things and in general, the code is good.
| @@ -1,46 +1,108 @@ | |||
| # Getting Started with Create React App | |||
| # Graasp App Template Typescript | |||
There was a problem hiding this comment.
For the end of the project, please create a README for your app:
- Put a description of the app
- Insert a screenshort
- Explain a few features that are working and list some features that you proposed to implement (even if you will not do it yourself).
You can make this in another branch. I will valid your PR without it. If you want to do that, please turn this comment into an issue.
There was a problem hiding this comment.
In the end, I already converted it into an issue. See #4
| "New App Data": "Créer une nouvelle donnée de l'App", | ||
| "Update Setting": "Mettre à jour le réglage", | ||
| "Local Context": "Contexte local", | ||
| "App Context": "Contexte de l'App", | ||
| "Members": "Membres" |
There was a problem hiding this comment.
Adapt translations. You can do that later if you want (then turn this comment into an issue).
|
done with these new changes |
Co-authored-by: lgodier <luna.godier@epfl.ch>
No description provided.