Fix lookup of metadata repository #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the URI which is constructed when only a version is set in the metadata repository. Before this change, whatever version was used in the configuration, we would ignore it, because we were testing against the wrong URI to figure out if the user had configured something explicitly or not. Now, we will prioritize the user URI, then construct a GitHub release URI from the version which is configured, and eventually use Maven Central if that URI is the same as the default one. Fixes #424
gradinac
approved these changes
Apr 6, 2023
|
If the build passes I will leave merging to @dnestoro since we're in the process of releasing 0.9.21 and that it would introduce a merge conflict. |
|
Since we finished the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the URI which is constructed when only a version is set in the metadata repository. Before this change, whatever version was used in the configuration, we would ignore it, because we were testing against the wrong URI to figure out if the user had configured something explicitly or not.
Now, we will prioritize the user URI, then construct a GitHub release URI from the version which is configured, and eventually use Maven Central if that URI is the same as the default one.
Fixes #424