Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip local GraalVM artifacts when not building from source #571

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Sep 14, 2023

Closes: #570

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 14, 2023
@zakkak zakkak requested a review from jerboaa September 14, 2023 10:58
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a CI run testing this? At least the local build one for mandrel & graalvm.

.github/workflows/base.yml Outdated Show resolved Hide resolved
.github/workflows/base.yml Outdated Show resolved Hide resolved
.github/workflows/base.yml Outdated Show resolved Hide resolved
@zakkak
Copy link
Collaborator Author

zakkak commented Sep 14, 2023

Do we have a CI run testing this? At least the local build one for mandrel & graalvm.

mandrel from source: https://github.com/zakkak/mandrel/actions/runs/6185883989
graalvm from source: https://github.com/zakkak/mandrel/actions/runs/6185892130
quay.io/quarkus/ubi-quarkus-mandrel-builder-image:jdk-17: https://github.com/zakkak/mandrel/actions/runs/6185839831

Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait for CI before you merge. Thanks!

@@ -65,7 +65,7 @@ on:

jobs:
delegate:
uses: graalvm/mandrel/.github/workflows/base.yml@default
uses: zakkak/mandrel/.github/workflows/base.yml@2023-09-14-fix-570
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it this will be reverted once CI completes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I better not forget it :)

@zakkak
Copy link
Collaborator Author

zakkak commented Sep 14, 2023

CI runs are good, TEMP commit dropped. I am merging.

@zakkak zakkak merged commit 9e18230 into graalvm:default Sep 14, 2023
@zakkak zakkak deleted the 2023-09-14-fix-570 branch September 14, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Quarkus build fails when using builder images.
2 participants