-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip local GraalVM artifacts when not building from source #571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a CI run testing this? At least the local build one for mandrel
& graalvm
.
f104823
to
0d5326b
Compare
mandrel from source: https://github.com/zakkak/mandrel/actions/runs/6185883989 |
0c842e7
to
df0513a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please wait for CI before you merge. Thanks!
.github/workflows/base-wrapper.yml
Outdated
@@ -65,7 +65,7 @@ on: | |||
|
|||
jobs: | |||
delegate: | |||
uses: graalvm/mandrel/.github/workflows/base.yml@default | |||
uses: zakkak/mandrel/.github/workflows/base.yml@2023-09-14-fix-570 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it this will be reverted once CI completes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I better not forget it :)
df0513a
to
10152a9
Compare
CI runs are good, TEMP commit dropped. I am merging. |
Closes: #570