Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move github api requests out of the way #711

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 22, 2024

This PR moves octokit and making an authenticated request to a point after it is determined that a PR is going to be created or updated.

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! But please remove the package-lock.json changes, that happens separately/automatically

@panva panva force-pushed the move-octokit.request branch from 3f93751 to d7855cc Compare November 14, 2024 06:34
@gr2m gr2m enabled auto-merge (squash) November 14, 2024 17:51
@gr2m gr2m closed this in #713 Nov 14, 2024
auto-merge was automatically disabled November 14, 2024 17:54

Pull request was closed

Copy link
Contributor

🎉 This issue has been resolved in version 1.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@panva panva deleted the move-octokit.request branch November 14, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants