Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename appdata file to metainfo #1321

Closed
wants to merge 1 commit into from
Closed

Rename appdata file to metainfo #1321

wants to merge 1 commit into from

Conversation

AsciiWolf
Copy link
Contributor

Not a big deal, but the metainfo.xml suffix is preferred nowadays. See the official AppStream documentation.

@AsciiWolf
Copy link
Contributor Author

The macOS CI fail is unrelated.

@AsciiWolf
Copy link
Contributor Author

@argilo Feel free to ask if you have any questions. :-)

@argilo
Copy link
Member

argilo commented Nov 19, 2023

I have considered this, but I didn't make the change because it would require many distribution maintainers to update their packaging. Do you think it's worth it?

@AsciiWolf
Copy link
Contributor Author

That's a very good point and you are probably right. We already install the file in a non-deprecated location and the .metainfo.xml suffix is more of a cosmetic thing since most AppStream parsers do not care much about the file suffix if it gets installed in a correct location. Thanks for your comment, I am closing this PR. :-)

@AsciiWolf AsciiWolf closed this Nov 19, 2023
@argilo
Copy link
Member

argilo commented Nov 19, 2023

It may still be worth slipping this in the next time there is a major change that requires packaging updates anyway (perhaps the same time as a switch from gr-osmosdr to gr-soapy, if and when that happens).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants