-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: add support for PipeWire audio backend #1319
Conversation
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
I don't understand this change. Gqrx does not have a PipeWire backend, and modifying the CMake won't change that. |
What problem are you trying to solve? Are you having trouble building Gqrx on Fedora? If so, what's going wrong? |
Hi @argilo, My apologies for the lack of context.
It turns out that Fedora uses PipeWire which has its own replacement for JACK::JACK. This sets the proper flags for PipeWire using Liam |
Do you have the |
I tried installing it, but it conflicts with |
OK. I suspect you've done something else wrong then. The Fedora project itself builds Gqrx packages without making any modifications to the CMake files: https://src.fedoraproject.org/rpms/gqrx/tree/rawhide I'll close this off for now, since the changes here shouldn't be necessary. |
It might be helpful to have a look over the https://src.fedoraproject.org/rpms/gqrx/blob/rawhide/f/gqrx.spec |
If you're still not able to build without modifications, feel free to open an issue and we can try to find an appropriate solution. |
I was just looking at that, I'm trying to see where my I'll try removing that and will reach out if I still have issues. Thanks for your time! |
For building with pipewire-jack-audio-connection-kit-devel package you must run |
add PipeWire support to build from source on Fedora F37+