fix: display calendar in a valid month when month prop is invalid #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpbl
reviewed
Jan 25, 2025
| @@ -96,7 +96,8 @@ export function useCalendar( | |||
| const initialMonth = getInitialMonth(props, dateLib); | |||
| const [firstMonth, setFirstMonth] = useControlledValue( | |||
| initialMonth, | |||
| props.month ? startOfMonth(props.month) : undefined | |||
| // initialMonth is always computed from props.month if provided | |||
| props.month ? initialMonth : undefined | |||
There was a problem hiding this comment.
Good catch! I always thought that useControlledValue call was hiding some bugs.
Worth to add a test case to getInitialMonth.test.ts. Would you add one? Thanks!
There was a problem hiding this comment.
For sure, just pushed more tests 👍
I think getInitialMonth.test.ts was testing well in most of the use cases with the month prop, but in any case, I expanded existing tests and added more.
Let me know if you think it would be useful to add tests for the useCalendar specifically. We may not need it because it's indirectly tested by other test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Passing a
monthprop that is outside thestartMonthandendMonthrange breaks the calendar.The PR fixes this edge case by always displaying a valid month as suggested in #2671 (comment).
Type of Change