Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies problem #61

Closed
g41797 opened this issue Apr 4, 2023 · 11 comments
Closed

Dependencies problem #61

g41797 opened this issue Apr 4, 2023 · 11 comments
Assignees

Comments

@g41797
Copy link
Contributor

g41797 commented Apr 4, 2023

maze.io/x/math32 - looks broken
Downloading failed with timeout
It isn't the problem of cxgo per se ,
just FYI
Thanks

@dennwc dennwc self-assigned this Apr 4, 2023
@dennwc
Copy link
Contributor

dennwc commented Apr 4, 2023

Indeed, looks like the server on that domain no longer responds. I will make a copy of that repo in the following days 👍

@g41797
Copy link
Contributor Author

g41797 commented Apr 5, 2023

As far as I understand, it's possible to use different math32 pkg:
https://github.com/chewxy/math32

It used within https://github.com/TotallyGamerJet/pgl/blob/main/portablegl.go
...
package pgl

import (
"encoding/binary"
"github.com/chewxy/math32"
"github.com/gotranspile/cxgo/runtime/cmath"
"math"
"unsafe"
)
..........

@dennwc
Copy link
Contributor

dennwc commented Apr 5, 2023

Good idea! Will use it instead.

In the meantime, you can add replace to go.mod to fix build:

replace maze.io/x/math32 => github.com/chewxy/math32

@g41797
Copy link
Contributor Author

g41797 commented Apr 5, 2023 via email

@dennwc
Copy link
Contributor

dennwc commented Apr 5, 2023

Yeah, looks like this won't work. I would hope for go mod tidy to fix it, but looks like it still needs some info about base repo.

I'll try to fix it sooner then.

@g41797
Copy link
Contributor Author

g41797 commented Apr 5, 2023 via email

@dennwc
Copy link
Contributor

dennwc commented Apr 5, 2023

It still uses it to type check generated code. Basically it takes signatures from it to generate (virtual) C headers. But yeah, in this case it could be avoided,since signatures are well-known.

@g41797
Copy link
Contributor Author

g41797 commented Apr 5, 2023 via email

@dennwc
Copy link
Contributor

dennwc commented Apr 5, 2023

Definitely!

@g41797
Copy link
Contributor Author

g41797 commented Apr 6, 2023 via email

@dennwc dennwc closed this as completed in 120c81d Apr 6, 2023
@dennwc
Copy link
Contributor

dennwc commented Apr 6, 2023

Fixed. Should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants