Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CONTRIBUTING.md #181

Merged

Conversation

eternal-flame-AD
Copy link
Member

No description provided.

@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner April 2, 2019 02:24
@eternal-flame-AD eternal-flame-AD removed the request for review from jmattheis April 2, 2019 02:24
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I like the different sections for "ways to contribute".

CONTRIBUTING.md Outdated
## Where to Contribute

- [gotify/server](https://github.com/gotify/server) - server implementation and WebUI code. Written in Golang and React Typescript.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? I kinda like using code formatting for the languages, then it looks like tags (:.

- [gotify/server](https://github.com/gotify/server) - the core of this project contains a web server and a web ui `Go` `TypeScript` `React`
- [gotify/android](https://github.com/gotify/android) - mobile app for managing gotify/server  `Java` `Android`
- [gotify/plugin-template](https://github.com/gotify/plugin-template) - template for plugins using [gotify/plugin-api](https://github.com/gotify/plugin-api) `Go`
- [gotify/cli](https://github.com/gotify/cli) - CLI for pushing messages to gotify/server `Go`
- [gotify/website](https://github.com/gotify/website) - documentation [gotify.net](https://gotify.net/) `Markdown`

Maybe we should also list gotify/contrib here something like gotify/contrib - community contribution requests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have formatted this section into a table so that it looks more lined-up and clean.

Co-Authored-By: eternal-flame-AD <ef@eternalflame.info>
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #181 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #181   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     40           
  Lines        1447   1447           
=====================================
  Hits         1447   1447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bbe17...3314c4e. Read the comment docs.

@eternal-flame-AD eternal-flame-AD merged commit 69f1d72 into gotify:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants