Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extra property to determine the content of messages #67

Merged
merged 1 commit into from
Apr 7, 2019
Merged

Use extra property to determine the content of messages #67

merged 1 commit into from
Apr 7, 2019

Conversation

jmattheis
Copy link
Member

No description provided.

eternal-flame-AD
eternal-flame-AD approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@eternal-flame-AD eternal-flame-AD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to merge for now but requires refactoring when implementing more extra features (more content types, or the 'fallback' mechanism like checking for android::* first and fallback to client::*, then fallback to global default).

@jmattheis
Copy link
Member Author

Yeah, for now I want to keep it more simple, and then we can see what exactly we need when implementing gotify/server#119 or something similar.

@jmattheis jmattheis merged commit be2b1e3 into master Apr 7, 2019
@jmattheis jmattheis deleted the markdown-from-extras branch April 7, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eternal-flame-AD eternal-flame-AD eternal-flame-AD approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmattheis @eternal-flame-AD