Skip to content

Commit

Permalink
Replacee breeze testing tests command in a few places remaining (ap…
Browse files Browse the repository at this point in the history
…ache#44299)

Follow up after apache#43979 to remove a few remaining places where
old `breeze testing tests` command was used.
  • Loading branch information
potiuk authored and got686-yandex committed Jan 30, 2025
1 parent e94246d commit 04adda6
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.ci
Original file line number Diff line number Diff line change
Expand Up @@ -1080,7 +1080,7 @@ function check_run_tests() {
if [[ ${REMOVE_ARM_PACKAGES:="false"} == "true" ]]; then
# Test what happens if we do not have ARM packages installed.
# This is useful to see if pytest collection works without ARM packages which is important
# for the MacOS M1 users running tests in their ARM machines with `breeze testing tests` command
# for the MacOS M1 users running tests in their ARM machines with `breeze testing *-tests` command
python "${IN_CONTAINER_DIR}/remove_arm_packages.py"
fi

Expand Down
3 changes: 2 additions & 1 deletion contributing-docs/05_pull_requests.rst
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ these guidelines:
to the changed code (for example for ``airflow/cli/cli_parser.py`` changes you have tests in
``tests/cli/test_cli_parser.py``). However there are a number of cases where the tests that should run
are placed elsewhere - you can either run tests for the whole ``TEST_TYPE`` that is relevant (see
``breeze testing tests --help`` output for available test types) or you can run all tests, or eventually
``breeze testing core-tests --help`` or ``breeze testing providers-tests --help`` output for
available test types for each of the testing commands) or you can run all tests, or eventually
you can push your code to PR and see results of the tests in the CI.

- You can use any supported python version to run the tests, but the best is to check
Expand Down
2 changes: 1 addition & 1 deletion dev/breeze/doc/03_developer_tasks.rst
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ are several reasons why you might want to do that.

Breeze uses docker images heavily and those images are rebuild periodically and might leave dangling, unused
images in docker cache. This might cause extra disk usage. Also running various docker compose commands
(for example running tests with ``breeze testing tests``) might create additional docker networks that might
(for example running tests with ``breeze testing core-tests``) might create additional docker networks that might
prevent new networks from being created. Those networks are not removed automatically by docker-compose.
Also Breeze uses it's own cache to keep information about all images.

Expand Down
8 changes: 4 additions & 4 deletions dev/breeze/doc/05_test_commands.rst
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ For example this will run API and WWW tests in parallel:

.. code-block:: bash
breeze testing tests --parallel-test-types "API WWW" --run-in-parallel
breeze testing core-tests --parallel-test-types "API WWW" --run-in-parallel
Here is the detailed set of options for the ``breeze testing tests`` command.
Here is the detailed set of options for the ``breeze testing core-tests`` command.

.. image:: ./images/output_testing_core-tests.svg
:target: https://raw.githubusercontent.com/apache/airflow/main/dev/breeze/images/output_testing_core-tests.svg
Expand Down Expand Up @@ -143,11 +143,11 @@ You can also run parallel tests with ``--run-in-parallel`` flag - by default it
in parallel, but you can specify the test type that you want to run with space separated list of test
types passed to ``--parallel-test-types`` flag.

For example this will run API and WWW tests in parallel:
For example this will run ``amazon`` and ``google`` tests in parallel:

.. code-block:: bash
breeze testing tests --parallel-test-types "Providers[amazon] Providers[google]" --run-in-parallel
breeze testing providers-tests --parallel-test-types "Providers[amazon] Providers[google]" --run-in-parallel
Here is the detailed set of options for the ``breeze testing providers-test`` command.

Expand Down
2 changes: 1 addition & 1 deletion scripts/docker/entrypoint_ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ function check_run_tests() {
if [[ ${REMOVE_ARM_PACKAGES:="false"} == "true" ]]; then
# Test what happens if we do not have ARM packages installed.
# This is useful to see if pytest collection works without ARM packages which is important
# for the MacOS M1 users running tests in their ARM machines with `breeze testing tests` command
# for the MacOS M1 users running tests in their ARM machines with `breeze testing *-tests` command
python "${IN_CONTAINER_DIR}/remove_arm_packages.py"
fi

Expand Down

0 comments on commit 04adda6

Please sign in to comment.