-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validation methods to python bindings #305
add validation methods to python bindings #305
Conversation
Hi @Machine-Maker, Apologies for the late reply. We had to focus on updating Pyo3 to support latest Python, some fixes regarding Python execution and #307. This looks great! Could you just move the main portion of the code to Rust (maybe to validate.rs) and export these functions. Then we can call them in Python, and export them to Python as well. We'll handle the case for other languages. Haven't forgotten for scientific JSON notation either, just want to merge couple of higher priority things first, and then we'll merge that one as well. EDIT: So you don't need to rebase and modify code twice, I'll let you know once #307 is merged, as there are additional changes coming to Python. |
Hi @Machine-Maker, The pull request linked above has been merged now. Happy to move this forward once above is fixed. Thanks! |
…lidate-expression
Ok, should be done. Not a super expert in rust, so if this isn't setup the best, please let me know. |
1747d9e
to
8a3c5cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After these 2 minor changes (naming) happy to merge (note to update also in the caller)
Ok, renamed |
Will need you to run |
Done |
Closes #304