fix: pass correct params to animateToPosition

[vonovak]

Motivation

animateToPosition accepts:

export type AnimateToPositionType = (
  position: number,
  source: ANIMATION_SOURCE,
  velocity?: number,
  configs?: Animated.WithTimingConfig | Animated.WithSpringConfig
) => void;

it was incorrectly called like this animateToPosition(context.initialPosition, velocityY / 2); - so velocityY / 2 was used in place of ANIMATION_SOURCE which is an enum.

According to this SO answer, TS does not distinguish between numbers and numeric Enums, which is why the error came to be in the first place. Let me know if you wanna change the enums to strings, I can add that to this PR (or open a new one).

There is one more change in src/hooks/useGestureEventsHandlersDefault.tsx - in this block I removed the first condtion and slightly simplified the second.

In the original code, if you look at the second condition you can see it is the same condition as the first one, just relaxed by the context.initialPosition === highestSnapPoint part. That means the second condition is a "superset" of the first and so the first can be removed (I hope I'm not wrong here :D).

if (
  (type === GESTURE_SOURCE.SCROLLABLE
    ? animatedScrollableContentOffsetY.value
    : 0) > 0 &&
  context.initialPosition === highestSnapPoint &&
  animatedPosition.value === highestSnapPoint
) {
  return;
}

/**
 * if gesture started by scrollable dragging the sheet than continue scrolling,
 * then exit the method to prevent snapping.
 */
if (
  type === GESTURE_SOURCE.SCROLLABLE &&
  animatedScrollableContentOffsetY.value > 0 &&
  animatedPosition.value === highestSnapPoint
) {
  return;
}

Thanks!

[gorhom]

everything looks fine, except this removed line

context.initialPosition === highestSnapPoint &&

[gorhom]

thanks @vonovak for spotting this issue 👏

[gorhom]

@all-contributors please add @vonovak for code

[allcontributors]

@gorhom

I've put up a pull request to add @vonovak! 🎉