Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image being blocked/hidden, shows as behind-the-scene request even when directly navigated to #260

Closed
ghost opened this issue May 29, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented May 29, 2015

https://a.pomf.se/dyionj.mp4
ABP does not exhibit the same symptom.

Browser: Firefox 38.0.1
OS: Windows 8.1 Professional x64
uBlock version: 0.9.8.2-dev.0

Steps to reproduce:
uBlock:

  1. Go to the uBlock dashboard
  2. Enable "Fanboy's Annoyance List"
  3. Open the logger
  4. Navigate to http://i0.kym-cdn.com/photos/images/facebook/000/820/090/0da.png
  5. Notice that the image is hidden
    apeyng 1
  6. Disable uBlock
  7. Notice that the image appears
  8. Look at the logger, notice how it doesn't report any hidden DOM elements, nor any blocked network requests, also notice how the image shows up as a behind-the-scene request

ABP:

  1. Subscribe to Fanboy's Annoyance list (https://www.fanboy.co.nz/)
  2. Navigate to http://i0.kym-cdn.com/photos/images/facebook/000/820/090/0da.png
  3. Notice that the image appears
  4. Disable ABP
  5. Notice that the image appears
    Reproduced with a clean profile.
    All filter lists were disabled except for EasyList and Fanboy's Annoyance. No custom dynamic filtering rules.
@gorhill
Copy link
Owner

gorhill commented May 29, 2015

I can reproduce, though my logger doesn't show the request as behind-the-scene.

Same underlying issue as gorhill/uMatrix#199.

Upon closer inspection, I can see that self.document is not HTMLDocument, but ImageDocument. Maybe I could use that information to prevent injecting the content scripts. I will look more into this.

As to why ABP does not have the issue it's just because it works differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant