Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements being hidden without notice #1124

Closed
ghost opened this issue Dec 27, 2015 · 3 comments
Closed

Elements being hidden without notice #1124

ghost opened this issue Dec 27, 2015 · 3 comments
Labels
accepted

Comments

@ghost
Copy link

ghost commented Dec 27, 2015

I found that if you open an image which has been blocked by uBO (e.g. https://airvpn.org/images/promotional/banner_641x91.gif from https://ipleak.net/) in a separate tab it will be hidden but uBO will neither show a blocked net request nor a counter for hidden elements. It also doesn't show up in the console or logger.

Edit: Made a video to demonstrate it: https://u.pomf.io/fvexdv.mp4
@ethus3h
Copy link

ethus3h commented Dec 28, 2015

I am unable to reproduce with Firefox 43.0.2.

Why anyone would willingly use Chrome/Chromium is beyond me, but perhaps that is the source of the issue?

@ghost
Copy link
Author

ghost commented Dec 28, 2015

I'm also no fan of Google and their control over the internet but Chrome usually runs smoother than Firefox (at least for me). Take a look at Chrome's and Firefox's market share. Your opinion is irrelevant here. And yes, this seems to only be an issue in Chromium based browsers.

@gorhill
Copy link
Owner

gorhill commented Dec 28, 2015

https://airvpn.org/images/promotional/banner_641x91.gif matches EasyList's ||airvpn.org/images/promotional/.

Even though the page URL address is https://airvpn.org/images/promotional/banner_641x91.gif, from uBO's content script's point of view, Chromium shows the document as being a standard HTML document, all with normal DOM structure (<!DOCTYPE ...><html><head>...</head><body>...</body></html>), with only one <img> node in its body element.

However, from uBO's HTTP observer's point of view, the network request to https://airvpn.org/images/promotional/banner_641x91.gif is not blocked, because it is labelled as being a document, not an image.

A similar issue was reported for FF: #260. The fix was made into FF-dependent code only at the time.

@gorhill gorhill closed this as completed in 4e7736b Jan 3, 2016
@zeridon zeridon mentioned this issue Jan 10, 2016
Closed
@gorhill gorhill mentioned this issue May 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @ethus3h