Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http:*?tid=$popup closes tabs that are neither ads or popups #1499

Closed
fluxtendu opened this issue Mar 24, 2016 · 3 comments
Closed

http:*?tid=$popup closes tabs that are neither ads or popups #1499

fluxtendu opened this issue Mar 24, 2016 · 3 comments

Comments

@fluxtendu
Copy link

This filter: http:*?tid=$popup (which is in the FRA: EasyList Liste FR‎) closes tabs that are neither ads or popups...

You could try to right click and open in a new tab this link to a post from the kodi forum: http://forum.kodi.tv/showthread.php?tid=252852.

Steps to reproduce:

  1. add FRA: EasyList Liste FR to your filter lists
  2. Right click and open in a new tab any link to a post from the kodi forum
  • Browser/version: Google Chrome 49.0.2623.87 m (64-bit)
  • uBlock Origin version: 1.6.4
@smed79
Copy link

smed79 commented Mar 24, 2016

Hi,
fixed, purge & update your filters lists.

@fluxtendu fluxtendu reopened this Mar 24, 2016
@fluxtendu
Copy link
Author

It's nice to have removed the filter from the list, but I'm not sure that's a normal behaviour for "$popup" to be active when a new tab is opened manually...

@gorhill
Copy link
Owner

gorhill commented Mar 24, 2016

I looked into this again this morning, with a rested mind.

not sure that's a normal behaviour for "$popup" to be active when a new tab is opened manually

A site could create an invisible <a> tag which covers the whole page, and a click on the page would be perceived as a normal click, and the popup would not be properly filtered and this case. So this was really a case of a way too broad popup filter.

@gorhill gorhill closed this as completed Mar 24, 2016
gorhill pushed a commit that referenced this issue Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants