Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar button in Pale Moon on Windows looks inconsistent #257

Closed
8 tasks done
JustOff opened this issue Aug 29, 2020 · 3 comments
Closed
8 tasks done

Toolbar button in Pale Moon on Windows looks inconsistent #257

JustOff opened this issue Aug 29, 2020 · 3 comments
Labels
enhancement New feature or request fixed

Comments

@JustOff
Copy link
Collaborator

JustOff commented Aug 29, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Toolbar button is too wide, has too much padding on both sides, and the icon is not symmetrically positioned.

Reported at https://forum.palemoon.org/viewtopic.php?t=25076&p=198154.

See also: uBlock-LLC/uBlock#1315, uBlock-LLC/uBlock#1321, uBlock-LLC/uBlock#1449, gorhill/uBlock#264.

A specific URL where the issue occurs

about:blank and everywhere

Steps to Reproduce

  1. Install uBlock Origin
  2. Make sure the button is placed on the main toolbar

Expected behavior:

palemoon_2020-08-29_12-57-15

Actual behavior:

palemoon_2020-08-29_12-53-21

Your environment

  • uBlock Origin version: 1.16.4.25
  • Browser Name and version: Pale Moon 28.12.0
  • Operating System and version: Windows 7 x64
@JustOff JustOff added the enhancement New feature or request label Aug 29, 2020
JustOff added a commit that referenced this issue Aug 29, 2020
This makes the button look consistent in Pale Moon on Windows, see #257. You can use the hidden setting `toolbarButtonForceTypeMenu` to revert to the previous design.

This also sets the button's `flip` attribute to` both` to improve the automatic positioning of the panel when the browser is not in full screen mode.
@JustOff
Copy link
Collaborator Author

JustOff commented Aug 29, 2020

Here is a beta version to test: uBlock0_1.16.4.26b1.firefox-legacy.xpi.zip (rename xpi.zip to xpi to install).

@epman100
Copy link

thanks. the recent beta version worked great with Palemoon 28.13.0 on my PC.
when will 1.16.4.26 be final?

@JustOff
Copy link
Collaborator Author

JustOff commented Sep 17, 2020

This will happen as soon as it's ready. Until then, you can safely use this beta.

@JustOff JustOff added the fixed label Nov 13, 2020
@JustOff JustOff closed this as completed Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed
Projects
None yet
Development

No branches or pull requests

2 participants